Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convert(Array,d) methods to avoid warnings #5641

Merged
merged 1 commit into from
Feb 4, 2014
Merged

Conversation

andreasnoack
Copy link
Member

No description provided.

@andreasnoack andreasnoack reopened this Feb 2, 2014
@andreasnoack
Copy link
Member Author

This should remove the warnings messages introduced by #5545. I have removed the convert method that didn't specify the parameter value of the array. I think this is more in line with how convert works for normal arrays, since you can't do convert(Array, sub(randn(5,5),1:4,1:4)). This change required update of the parallel tests.
cc: @amitmurthy, @JeffBezanson

@amitmurthy amitmurthy closed this Feb 3, 2014
@amitmurthy amitmurthy reopened this Feb 3, 2014
@amitmurthy
Copy link
Contributor

Sorry for the close/reopen ! Anyway, would like Jeff/others who have a stronger understanding of Julia's Types and its intricacies to take a call on this.

@kmsquire
Copy link
Member

kmsquire commented Feb 4, 2014

@amitmurthy, what kind of call are you looking for? The current behavior is clearly wrong, as it is giving off warnings.

Since there isn't an obvious easy fix (other than this one), my suggestion is to commit this fix, and if necessary, open up a separate issue for any missing convert methods you think are needed.

@amitmurthy
Copy link
Contributor

I just meant that I may not be the best judge of this PR.

Merging now. Can revert in case of any issues.

amitmurthy added a commit that referenced this pull request Feb 4, 2014
Remove convert(Array,d) methods to avoid warnings
@amitmurthy amitmurthy merged commit 32925ec into master Feb 4, 2014
@kmsquire
Copy link
Member

kmsquire commented Feb 4, 2014

Thanks, and no worries. Sorry if I came across a bit blunt... I should probably go to bed. Cheers!

@andreasnoack andreasnoack deleted the anj/darray branch February 4, 2014 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants