make two globals in loading.jl into ScopedValues #56378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Oct 29, 2024
|
This seems strictly better in that case, since at least the value that the task sees is well defined rather than randomly switching off at a non-deterministic point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems less brittle to have this be ScopedValues when there is work going on for parallel loading etc.
If we go with this, this also needs to be updated:
https://github.com/JuliaLang/Distributed.jl/blob/729ba6aa45a9c3e1d492b53ecb9f6190f05f6428/src/Distributed.jl#L81