Add tests for alignment of Int128/UInt128
#55565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/test-alignment-int128
branch
from
633b18f to
bb8296e
Compare
giordano
changed the title
Int128Int128/UInt128
|
Int128 is currently 16 byte aligned on i686, but not for PowerPC or arm. EDIT: Looks like PowerPC is supposed to be 16 byte aligned, llvm/llvm-project#102783, https://refspecs.linuxfoundation.org/ELF/ppc64/PPC-elf64abi.html#FUND-TYPE. |
|
Uhm, this is indeed failing on powerpc: https://buildkite.com/julialang/julia-master/builds/39418#01917a85-4823-4170-a03b-72cde2879c46/840-1424. I'll mark the test as broken on that platform then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vchuravy is this enough for test the alignment? Note: I tested this on aarch64 and x86_64, I'm not sure of the alignment value on powerpc64le, i686 or arm.
Fix #55558.