add public statement to Base.Broadcast

[matthias314]

This PR makes the following symbols from Base.Broadcast public:

• Symbols appearing in the documentation, with docstring

AbstractArrayStyle
ArrayStyle
Broadcasted
DefaultArrayStyle
Style
combine_axes
combine_styles
flatten
instantiate
result_style

• Symbols appearing in the documentation, without docstring

Unknown

• Symbols not appearing in the documentation, with docstring

materialize

I think it makes sense to make it public given that Broadcasted is also public.

• Symbols not appearing in the documentation, without docstring

DefaultMatrixStyle
DefaultVectorStyle

I think it makes sense to have them available as shortcuts. Maybe one should even mention them in the documentation instead of using DefaultArrayStyle{1}, for example.

EDIT: Making DefaultVectorStyle and DefaultMatrixStyle public leads to failing doctests because they now appear in the Julia output instead of DefaultArrayStyle{1} and DefaultArrayStyle{2}. However, they are never used in broadcast.jl. If one doesn't want to have them public, why are they defined at all? Let me know if you want to have them public. Then I adjust the documentation.

• The following functions have been left out although they have docstrings:

broadcast_preserving_zero_d
broadcast_shape
make_makeargs
newindex
_broadcast_getindex

• The following symbol (with docstring) is currently exported without appearing in the documentation:

BroadcastFunction

[matthias314]

I've removed DefaultVectorStyle and DefaultMatrixStyle from the list of public symbols.

[matthias314]

@LilithHafner Any feedback on this?

[LilithHafner]

Thanks for the bump.

• I don't think we should mark anything without a docstring as public without also adding a docstring.
• I don't know the broadcast internals well enough to provide robust feedback on the specific choices here but I'll try to find someone(s) who is.

[matthias314]

Any news?

I can add a docstring for Broadcast.Unknown if you want. The only occurrence of Unknown is in some output inside the examples section of the docstring for Broadcast.result_style. If we work on this, should we also consider renaming it? I think that UnknownStyle would be more informative.