Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dependencies of extensions be found in implicit environments #53314

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented Feb 13, 2024

Alternative to #53293

This does kind of the same thing but it does not rely on EXT_PRIMED to identify extensions which I think is a better idea since we don't really want code lookup to depend on the state of Julia itself imo.

Fixes #53264

cc @mkitti


Co-authored by: Mark Kittisopikul <markkitti@fosstodon.org>

Co-authored by: Mark Kittisopikul <markkitti@fosstodon.org>
@KristofferC KristofferC added domain:packages Package management and loading kind:bugfix This change fixes an existing bug labels Feb 13, 2024
@KristofferC KristofferC added this to the 1.11 milestone Feb 13, 2024
@IanButterworth
Copy link
Sponsor Member

Fixes #53264 ?

base/loading.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC merged commit a19fbac into master Feb 14, 2024
5 of 7 checks passed
@KristofferC KristofferC deleted the kc/env_implicit branch February 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:packages Package management and loading kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current master always re-precompiles REPLExt when entering pkg>-mode in a clean environment
2 participants