-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for the Markdown Macro #52607
Conversation
I would love to help fixing the failed tests with some help. I'm still very new to contributing to projects so I don't quite understand why these tests are failing. |
The build system fails as some formatting tests are not passing. I'm guessing there are some undesired blank lines? What output does However, is there a particular reason why you've wanted to create your own PR instead of contributing to #52606 ? |
When I started working on this issue there was no PR relating to this. Looks like it was made a few minutes before I made mine. |
This means that you need to add one newline at the end of the file.
Funny coincidence :-) So, which of the two PRs should we complete? I'd personally would like to keep the added docstring for the macro in the source file, but I don't have strong opinions how the |
We could have 2 seperate PRs maybe? Yours for the docstring and mine for the docs/index.md? Again, not sure if this is how it works here since I'm new to contributing. |
It seems you've gone from "no newline at end of file" to "too many newlines at end of file". The enforced style is "the last line with content should have another newline character, but then, there should be no more empty lines". Hope this helps. As for the communal aspect: this is also my very first contribution to Julia, so I'm also unaware of these guidelines. I guess we'll just have to wait what the moderators say. However, if you want to, I could give you write access to my fork (or vice versa) and we could converge in one PR. Maybe that would make it easier for the mods as well? |
Added documentation for the
md_str()
macro which is used bymd""
.Mentioned in #51168.