-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sizehint!
docstring about shrink
arg
#52226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
added
docs
This change adds or pertains to documentation
collections
Data structures holding multiple items, e.g. sets
labels
Nov 18, 2023
5 tasks
matthias314
reviewed
Nov 18, 2023
petvana
reviewed
Nov 20, 2023
petvana
reviewed
Nov 20, 2023
Since we are talking about the docstring for
(which is not changed at present). I don't find the phrase "reserved from the start of the collection" very clear. What about the following:
|
I've pushed a commit to apply the proposed changes. |
petvana
reviewed
Dec 4, 2023
petvana
reviewed
Dec 4, 2023
Co-authored-by: Petr Vana <petvana@gmail.com>
nalimilan
commented
Dec 10, 2023
petvana
reviewed
Dec 10, 2023
nalimilan
commented
Dec 10, 2023
petvana
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
collections
Data structures holding multiple items, e.g. sets
docs
This change adds or pertains to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #51929 (comment).