allow destructive inlining only when the source is volatile #52062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your benchmark job has completed - no performance regressions were detected. A full report can be found here. |
Destructive inlining introduced by #51934 implicitly presupposes that inferred `CodeInfo` source has been compressed to the `String` format when cached, which is not generally true for external `AbstractInterpreter`s that may disable the `may_compress` and/or `may_discard_trees` settings. This commit adds a safeguard to ensure the eligibility of such `CodeInfo` source propagated by `VolatileInferenceResult` for destructive inlining.
aviatesk
force-pushed
the
avi/is_src_volatile
branch
from
7c66928 to
1ec2ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructive inlining introduced by #51934 implicitly presupposes that inferred
CodeInfosource has been compressed to theStringformat when cached, which is not generally true for externalAbstractInterpreters that may disable themay_compressand/ormay_discard_treessettings. This commit adds a safeguard to ensure the eligibility of suchCodeInfosource propagated byVolatileInferenceResultfor destructive inlining.@nanosoldier
runbenchmarks("inference", vs=":master")