Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add some clarifications to methods.md #51938

Merged
merged 2 commits into from
Nov 1, 2023
Merged

docs: add some clarifications to methods.md #51938

merged 2 commits into from
Nov 1, 2023

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Oct 30, 2023

Closes #40650
Rebase of #40667 with edits, since upstream deleted their repo

Closes #40650
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added the domain:docs This change adds or pertains to documentation label Oct 30, 2023
@vtjnash vtjnash mentioned this pull request Oct 30, 2023
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Oct 31, 2023
@vtjnash vtjnash merged commit 5db9dbd into master Nov 1, 2023
6 of 8 checks passed
@vtjnash vtjnash deleted the pr40667 branch November 1, 2023 14:42
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Nov 2, 2023
@mpeters2
Copy link

Instead of using single-line functions for your examples, can you use multiline function definitions when possible? For those of us who do not live in the REPL, those types of examples can be confusing, as they do not follow our usual coding style.

For example, instead of this (which is a function that doesn't do anything, or at least it is non-obvious):

julia> bar(a, b, x...) = (a, b, x)
bar (generic function with 1 method)

this:

function bar(a, b, x...)
    println("a = ", a)
    println("b = ", b)
    println("x... = ", x)
end

julia> bar(1, 2, 3, 4)
a = 1
b = 2
x... = (3, 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some questions about manual/methods.md
4 participants