Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't mark nonlocal symbols as hidden" #51571

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

vchuravy
Copy link
Sponsor Member

@vchuravy vchuravy commented Oct 3, 2023

Reverts #51530

in response to #51530 (comment)

@vchuravy
Copy link
Sponsor Member Author

vchuravy commented Oct 3, 2023

@IanButterworth says in particular this is Windows. Which I might have missed in the failure noise.

@vchuravy vchuravy added the status:merge me PR is reviewed. Merge when all tests are passing label Oct 3, 2023
@IanButterworth
Copy link
Sponsor Member

IanButterworth commented Oct 3, 2023

@IanButterworth IanButterworth merged commit b790cf8 into master Oct 3, 2023
6 of 7 checks passed
@IanButterworth IanButterworth deleted the revert-51530-pc/ccallable-extern branch October 3, 2023 20:35
vchuravy added a commit that referenced this pull request Oct 5, 2023
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants