Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop running finalizers on exit #51466

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Stop running finalizers on exit #51466

wants to merge 7 commits into from
+12 −95

Commits on Oct 11, 2023

  1. Do not run finalizers on exit 

    This has caused a number of problems like freezes on exit. Other language
runtimes (Java, .NET, Go) have also made the decision to no longer run
finalizers on exit.

Remove call to `jl_gc_run_all_finalizers()` and the function itself.
    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    3fbc40a View commit details
    Browse the repository at this point in the history

  2. Drop test that relies on finalizers running at exit 

    The test verifies that `atexit`s cannot be registered once Julia
has started exiting and has run the already-registered `atexit`s.
    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    43dfdb9 View commit details
    Browse the repository at this point in the history

  3. Update docs to remove all references to running finalizers at exit

    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    df30ac4 View commit details
    Browse the repository at this point in the history

  4. Update NEWS

    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c81708f View commit details
    Browse the repository at this point in the history

  5. Back-out PR #19911 

    Since we no longer run finalizers at exit.
    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c3f5c3a View commit details
    Browse the repository at this point in the history

  6. Back out test for #26687 

    Relies on finalizers running at exit.
    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5dde085 View commit details
    Browse the repository at this point in the history

  7. Update finalizer docstring 

    Add a `compat` note that as of Julia 1.11, finalizers will not be run
on exit.
    @kpamnany
    kpamnany committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1add939 View commit details
    Browse the repository at this point in the history