Fix rdiv of complex lhs by real factorizations #50671
Conversation
|
The "removed" |
True, but transpose real is simply unnecessary given that it's equivalent to adjoint real. Anyway, test failures look unrelated (though some of them are a bit scary), so this seems to be on a good track. |
Co-authored-by: Martin Holters <martin@holters.name>
dkarrasch
added
domain:linear algebra
|
All green CI! I'm not 100% sold this qualifies as a bugfix. Is there anything that gives a wrong result without this PR or gives an error while it used to work in an earlier version? But even if it does not, I'm still in favor of backporting, as 1.10 is not yet released and this indeed is cleanup to #46874 worth including in the release. (It also adds a feature, so I'd be reluctant to backport it to 1.10.1). |
| rdiv!(copy_similar(B, TFB), F) | ||
| end | ||
| # reinterpretation trick for complex lhs and real factorization | ||
| function (/)(B::Union{Matrix{Complex{T}},Adjoint{Complex{T},Vector{Complex{T}}},Transpose{Complex{T},Vector{Complex{T}}}}, F::Factorization{T}) where {T<:BlasReal} |
There was a problem hiding this comment.
Uh, this line is quite long. I'm not sure how best to wrap it though. The extreme other end would be
| function (/)(B::Union{Matrix{Complex{T}},Adjoint{Complex{T},Vector{Complex{T}}},Transpose{Complex{T},Vector{Complex{T}}}}, F::Factorization{T}) where {T<:BlasReal} | |
| function (/)( | |
| B::Union{ | |
| Matrix{Complex{T}}, | |
| Adjoint{Complex{T},Vector{Complex{T}}}, | |
| Transpose{Complex{T},Vector{Complex{T}}} | |
| }, | |
| F::Factorization{T} | |
| ) where {T<:BlasReal} |
Maybe there is some reasonable middle-ground?
| return copy(reinterpret(Complex{T}, x)) | ||
| end | ||
| # don't do the reinterpretation for [Adjoint/Transpose]Factorization | ||
| (/)(B::Union{Matrix{Complex{T}},Adjoint{Complex{T},Vector{Complex{T}}},Transpose{Complex{T},Vector{Complex{T}}}}, F::TransposeFactorization{T}) where {T<:BlasReal} = |
|
Yeah, "bugfix" might be a bit misleading, but there were typos in the |
|
There's for more than one CI job. Can that possibly be related? I couldn't explain how. |
|
Ah, the CI failures I worried about are #50550, so unrelated (as expected). |
Co-authored-by: Martin Holters <martin@holters.name> (cherry picked from commit 210c5b5)
Backported PRs: - [x] #50637 <!-- Remove SparseArrays legacy code --> - [x] #50665 <!-- print `@time` msg into print buffer --> - [x] #50523 <!-- Avoid generic call in most cases for getproperty --> - [x] #50635 <!-- `versioninfo()`: include build info and unofficial warning --> - [x] #50670 <!-- Make reinterpret specialize fully. --> - [x] #50666 <!-- include `--pkgimage=no` caches for stdlibs --> - [x] #50765 - [x] #50764 - [x] #50768 - [x] #50767 - [x] #50618 <!-- inference: continue const-prop' when concrete-eval returns non-inlineable --> - [x] #50689 <!-- Attach `tanpi` docstring to method --> - [x] #50671 <!-- Fix rdiv of complex lhs by real factorizations --> - [x] #50598 <!-- only limit types in stack traces in the REPL --> - [x] #50766 <!-- Don't partition alwaysinline functions --> - [x] #50771 <!-- re-allow non-string values in ENV `get!` --> - [x] #50682 <!-- Add fallback if we have make a weird GC decision. --> - [x] #50781 <!-- fix `bit_map!` with aliasing --> - [x] #50172 <!-- print feature flags used for matching pkgimage --> - [x] #50844 <!-- Bump OpenBLAS binaries to use the new GEMM multithreading threshold --> - [x] #50826 <!-- Update dependency builds --> - [x] #50845 <!-- fix #50438, use default pool for at-threads --> - [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` --> - [x] #50655 <!-- fix hashing regression. --> - [x] #50779 <!-- Minor refactor to image generation --> - [x] #50791 <!-- Make symbols internal in jl_create_native, and only externalize them when partitioning --> - [x] #50724 <!-- Merge opaque closure modules with the rest of the workqueue --> - [x] #50738 <!-- Add alignment to constant globals --> - [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception handling. --> Need manual backport: Contains multiple commits, manual intervention needed: Non-merged PRs with backport label: - [ ] #50850 <!-- Remove weird Rational dispatch and add pi functions to list --> - [ ] #50823 <!-- Make ranges more robust with unsigned indexes. --> - [ ] #50809 <!-- Limit type-printing in MethodError --> - [ ] #50663 <!-- Fix Expr(:loopinfo) codegen --> - [ ] #50594 <!-- Disallow non-index Integer types in isassigned --> - [ ] #50385 <!-- Precompile pidlocks: add to NEWS and docs --> - [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
KristofferC
removed
the
backport 1.10
This fixes overseen typos, contained in untested methods, and fixes #50617. The faulty methods were introduced in #46874 and need to be backported to v1.10.
@martinholters