Tweak cache pidlocking #50214
Merged
Tweak cache pidlocking #50214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barucden
reviewed
Jun 19, 2023
Update base/loading.jl Update loading.jl
IanButterworth
force-pushed
the
ib/cache_pidfile_path
branch
from
9d56cd2
to
a6ba71f
Compare
|
I'm going to merge this to get PkgEval working again. Further tweaks welcomed |
vtjnash
reviewed
Jun 21, 2023
vtjnash
reviewed
Jun 21, 2023
|
Thanks for fixing those. Sorry for the slow review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50206
Moves the pidfile from the package source to the depot. The pidlock is now specific to the cachefile but ignoring any preferences (which would change the cachefile path) as the prefs hash can only be determined after precompilation.
@vchuravy
Fixes #50213
Stale pidfile rejection was unintentionally disabled,
stale_ageshould have been set. I'm proposing 60 seconds. See comments for explanation.@maleadt