Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profile] fix overhead counts in format=:flat #49824

Merged
merged 1 commit into from
May 16, 2023
Merged

[Profile] fix overhead counts in format=:flat #49824

merged 1 commit into from
May 16, 2023

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented May 15, 2023

Regression caused by #41742, which inverted the loop without inverting the logic. And fix a number of related formatting mistakes.

Fix #49732

@vtjnash
[Profile] fix overhead counts in format=:flat
ec8b586 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732
@vtjnash vtjnash added profiler backport 1.9 Change should be backported to release-1.9 labels May 15, 2023
@vtjnash vtjnash merged commit 45748b8 into master May 16, 2023
@vtjnash vtjnash deleted the jn/49732 branch May 16, 2023 20:14
KristofferC pushed a commit that referenced this pull request May 19, 2023
@vtjnash
[Profile] fix overhead counts in format=:flat (#49824)
c0e2507 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
@KristofferC KristofferC mentioned this pull request May 19, 2023
Merged
51 tasks
KristofferC pushed a commit that referenced this pull request May 27, 2023
@vtjnash @KristofferC
[Profile] fix overhead counts in format=:flat (#49824)
f07ed54 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label May 28, 2023
kpamnany pushed a commit that referenced this pull request Jun 21, 2023
@vtjnash @kpamnany
[Profile] fix overhead counts in format=:flat (#49824)
f7b0953 
Regression caused by #41742, which inverted the loop without inverting
the logic. And fix a number of related formatting mistakes.

Fix #49732

(cherry picked from commit 45748b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
profiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

profile format=:flat has wrong overhead
2 participants
@vtjnash @KristofferC