Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose JL_TIMING tracking to VTune #49448

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Expose JL_TIMING tracking to VTune #49448

merged 1 commit into from
Apr 22, 2023

Conversation

pchintalapudi
Copy link
Member

Examples:
image
image

@@ -2957,7 +2957,7 @@ static int _jl_gc_collect(jl_ptls_t ptls, jl_gc_collection_t collection)
uint64_t start_mark_time = jl_hrtime();
JL_PROBE_GC_MARK_BEGIN();
{
JL_TIMING(GC, Mark);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topolarity Is there a way to attach a message? Would be helpful to differentiate between minor and major GC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Tracy, we distinguish full sweeps based on the color associated with the event. That's one of the cases we haven't pulled up to a generic API yet:

julia/src/gc.c

Lines 3122 to 3127 in 552dd4c

#ifdef USE_TRACY
if (sweep_full) {
TracyCZoneCtx ctx = *(JL_TIMING_CURRENT_BLOCK->tracy_ctx);
TracyCZoneColor(ctx, 0xFFA500);
}
#endif

jl_timing_printf and jl_timing_show_* also allow associating strings with events, so we could use that if ITTAPI supports string metadata. Or did you have something more specialized in mind?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like if we had a conditional event that would be sufficient here.

Base automatically changed from pc/ittapi-uds to master April 21, 2023 14:54
@vchuravy vchuravy merged commit a34261f into master Apr 22, 2023
@vchuravy vchuravy deleted the pc/ittapi-events branch April 22, 2023 20:44
@topolarity
Copy link
Member

Late to the review, but once again nice work - Nice to have this on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants