Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting missing values with offset indices #48864

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Fix sorting missing values with offset indices #48864

merged 2 commits into from
Mar 6, 2023

Conversation

LilithHafner
Copy link
Member

Fixes #48862

@LilithHafner LilithHafner added needs tests Unit tests are required for this change bugfix This change fixes an existing bug missing data Base.missing and related functionality sorting Put things in order backport 1.9 Change should be backported to release-1.9 labels Mar 2, 2023
@LilithHafner LilithHafner removed the needs tests Unit tests are required for this change label Mar 2, 2023
@KristofferC KristofferC mentioned this pull request Mar 3, 2023
Merged
50 tasks
@LilithHafner
Copy link
Member Author

Bump

@N5N3 N5N3 merged commit 7eb9615 into master Mar 6, 2023
@N5N3 N5N3 deleted the LilithHafner-patch-4 branch March 6, 2023 03:35
KristofferC pushed a commit that referenced this pull request Mar 6, 2023
@LilithHafner @KristofferC
Fix sorting missing values with offset indices (#48864)
e6249e7 
* Fix sorting missing values with offset indices

* Add tests

(cherry picked from commit 7eb9615)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug missing data Base.missing and related functionality sorting Put things in order
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting an OffsetArray with missing values throws BoundsError
3 participants
@LilithHafner @KristofferC @N5N3