Commits on Jan 4, 2023

1. Don't perform extra inference during incremental image creation …

   As noted in #48047, we're currently attempting to infer extra
   methods during incremental image saving, which causes us to miss
   edges in the image. In particular, in the case of #48047, Cthulhu
   had the `compile=min` option set, which caused the code instance
   for `do_typeinf!` to not be infered. However, later it was
   nevertheless queued for precompilation, causing inference to
   occur at an inopportune time.
   
   This PR simply prevents code instances that don't explicitly have
   the `->precompile` flag set (e.g. the guard instance created for
   the interpreter) from being enqueued for precompilation. It is
   not clear that this is necessarily the correct behavior - we may
   in fact want to infer these method instances, just before we set
   up the serializer state, but for now this fixes #48047 for me.
   
   I also included an appropriate test and a warning message if
   we attempt to enter inference when this is not legal, so any
   revisit of what should be happening here can hopefully make
   use of those.

   

   Keno committed Jan 4, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 95d75d1
   • Browse repository at this point

   Copy the full SHA

   95d75d1 View commit details

   Browse the repository at this point in the history