Prioritize build_dir for generated headers #47783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
added
the
domain:building
vchuravy
added
backport 1.6
KristofferC
pushed a commit
that referenced
this pull request
Dec 8, 2022
(cherry picked from commit 0feaf5c)
51 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 0feaf5c)
26 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit 0feaf5c)
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #47755
Builds are compiled with:
For out-of-tree builds this should mean that we prioritize the build dir.
Using
-Hwe observe that if a generated header is present in the src dir:This is due to the semantics of
#include "file"vs#include <file>in the C pre-processor.The former is relative to the current header/source file, while the later uses the include directories.
After this change we observe: