Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlining: follow up #47371, remove unused override_effects keyword arg #47762

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Dec 1, 2022

This keyword argument was introduced by #47305, which was then reverted by #47371. Now it's dead, so let's remove it.

This keyword argument was introduced by #47305, which was then reverted
by #47371. Now it's dead, so let's remove it.
@brenhinkeller brenhinkeller added the compiler:effects effect analysis label Dec 1, 2022
@aviatesk
Copy link
Member Author

aviatesk commented Dec 1, 2022

@brenhinkeller The label effects doesn't probably very fit with this PR (since it's supposed to be put on direct changes on the effect system) but rather the optimizer label does because this PR changes some implementation detail of the inlining algorithm. I'd appreciate if you add labels when you're sure they apply.

@aviatesk aviatesk added compiler:optimizer Optimization passes (mostly in base/compiler/ssair/) and removed compiler:effects effect analysis labels Dec 1, 2022
@brenhinkeller
Copy link
Contributor

Sure -- currently the "effects" tag description is very generic though FWIW.

@aviatesk
Copy link
Member Author

aviatesk commented Dec 1, 2022

Yeah, to elaborate a bit, it's a part of our abstract interpretation algorithm so it'd apply when we change some code within base/compiler/[abstractinterpretation|tfuncs|typeinfer.jl].

@aviatesk aviatesk requested a review from Keno December 1, 2022 09:27
@aviatesk aviatesk merged commit a9e6b5a into master Dec 1, 2022
@aviatesk aviatesk deleted the avi/follow-47371 branch December 1, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:optimizer Optimization passes (mostly in base/compiler/ssair/)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants