Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading info on the difference between "using" and "import" #47614

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Fix misleading info on the difference between "using" and "import" #47614

merged 3 commits into from
Feb 10, 2023

Conversation

udohjeremiah
Copy link
Contributor

This fixes #43425

@udohjeremiah udohjeremiah changed the title Fix #43425 Fix misleading info on the difference between "using" and "import" Nov 17, 2022
@udohjeremiah udohjeremiah added the docs This change adds or pertains to documentation label Nov 17, 2022
logankilpatrick
logankilpatrick reviewed Nov 20, 2022
View reviewed changes
Copy link
Member

@logankilpatrick logankilpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a worthwhile link to add. I am not personally crazy about the wording of the first sentence but don't have any suggestions right now on how to make it any better.

@udohjeremiah
Copy link
Contributor Author

I think you're right. Maybe using Among is better than Aside.

@udohjeremiah @halleysfifthinc
Update doc/src/manual/faq.md
a8a8aa6 
Co-authored-by: Allen Hill <halleysfifthinc@users.noreply.github.com>
brenhinkeller
brenhinkeller reviewed Nov 26, 2022
View reviewed changes
doc/src/manual/faq.md
you only need to say `function bar(...` and it automatically extends module Foo's function bar.
There are several differences between `using` and `import`
(see the [Modules section](https://docs.julialang.org/en/v1/manual/modules/#modules)),
but there is an important difference that may not seem intuitive at first glance,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps "including in particular one important difference that may not seem" instead of "but there is an important difference that may not seem"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding this sentence, where does using and import comes?

Can you please provide a complete suggestion so I see where the using and import comes in?

@vtjnash vtjnash merged commit d6baad6 into JuliaLang:master Feb 10, 2023
@udohjeremiah udohjeremiah deleted the patch-37 branch February 12, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logankilpatrick logankilpatrick logankilpatrick left review comments

@brenhinkeller brenhinkeller brenhinkeller left review comments

@halleysfifthinc halleysfifthinc halleysfifthinc left review comments

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAQ on difference between "using" and "import" misleading?
5 participants
@udohjeremiah @halleysfifthinc @brenhinkeller @logankilpatrick @vtjnash