compiler: Get rid of has_struct_const_info #46564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced by me in #39684, but the commit message has no discussion as to why `has_struct_const_info` and `has_nontrivial_const_info` are not the same function. Moreover, I don't think the `isa(x, Conditional)` branch ever did anything because even at the time of the commit, `tuple_tfunc` applied `widenconditional` to all incoming argtypes. That leaves `PartialTypeVar`, which seems reasonable to just include in the definition of `has_nontrivial_const_info`, so that we may be consistent between `tuple_tfunc` and `Expr(:new)`.
aviatesk
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced by me in #39684, but the commit message has
no discussion as to why
has_struct_const_infoandhas_nontrivial_const_infoare not the same function.Moreover, I don't think the
isa(x, Conditional)branch everdid anything because even at the time of the commit,
tuple_tfuncapplied
widenconditionalto all incoming argtypes. That leavesPartialTypeVar, which seems reasonable to just include in thedefinition of
has_nontrivial_const_info, so that we may beconsistent between
tuple_tfuncandExpr(:new).