Check that MethodInstance.def is Method #46148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may fix #45444
|
@nanosoldier |
vtjnash
reviewed
Jul 25, 2022
Comment on lines
+1303
to
+1304
| assert(jl_is_method_instance(caller)); | ||
| if (jl_is_method(caller->def.method) && (module_in_worklist(caller->def.method->module) || method_instance_in_queue(caller))) { |
There was a problem hiding this comment.
AFIAK, we should never see this happen (since Core.Compiler.store_backedges shouldn't make these edges). Though we could also have jl_method_instance_add_backedge ensure that it does not create them too.
Suggested change
| assert(jl_is_method_instance(caller)); | |
| if (jl_is_method(caller->def.method) && (module_in_worklist(caller->def.method->module) || method_instance_in_queue(caller))) { | |
| assert(jl_is_method_instance(caller) && jl_is_method(caller->def.method)); | |
| if (module_in_worklist(caller->def.method->module) || method_instance_in_queue(caller))) { |
|
Your package evaluation job has completed - possible new issues were detected. A full report can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may fix #45444. The alternative possibility is that #45444 is a GC-related issue, but this change may be worth having anyway.