Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timev compilation time tracking and add tests #46100

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

IanButterworth
Copy link
Member

As noted by @NHDaly https://github.com/JuliaLang/julia/pull/45015/files#r924872101 @timev compilation timing wasn't turned on after changes in #45015

@IanButterworth IanButterworth added the backport 1.8 Change should be backported to release-1.8 label Jul 19, 2022
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @IanButterworth! 👍

base/timing.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth merged commit f3c2227 into JuliaLang:master Jul 20, 2022
@IanButterworth IanButterworth deleted the ib/fix_timev branch August 1, 2022 16:19
IanButterworth added a commit that referenced this pull request Aug 1, 2022
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Aug 7, 2022
ffucci pushed a commit to ffucci/julia that referenced this pull request Aug 11, 2022
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants