Resurrect deps/patches/llvm-libunwind-prologue-epilogue.patch
#45175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally removed in a previous PR but it's necessary to build LLVM libunwind from source on macOS.
giordano
added
building
vchuravy
approved these changes
May 4, 2022
|
Ideally we would add CI for this, but it only occurs on Mac and we are resource constrained in CI time. |
|
Still does not build: See this comment: #44499 (comment) |
|
I think the adapted version of the second patch could be this: https://gist.github.com/fxcoudert/1095f33d271c27f4cac63fc0ea37e0c0 |
67 tasks
|
Superseded by #45189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally removed in a previous PR but it's necessary to build LLVM
libunwind from source on macOS.
This should hopefully fix #44499. CC: @fxcoudert