Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resurrect deps/patches/llvm-libunwind-prologue-epilogue.patch #45175

Closed
wants to merge 1 commit into from

Conversation

giordano
Copy link
Contributor

@giordano giordano commented May 3, 2022

This was accidentally removed in a previous PR but it's necessary to build LLVM
libunwind from source on macOS.

This should hopefully fix #44499. CC: @fxcoudert

This was accidentally removed in a previous PR but it's necessary to build LLVM
libunwind from source on macOS.
@giordano giordano added building Build system, or building Julia or its dependencies system:mac Affects only macOS external dependencies Involves LLVM, OpenBLAS, or other linked libraries backport 1.8 Change should be backported to release-1.8 labels May 3, 2022
@vchuravy
Copy link
Member

vchuravy commented May 4, 2022

Ideally we would add CI for this, but it only occurs on Mac and we are resource constrained in CI time.

@fxcoudert
Copy link
Contributor

Still does not build:

make[2]: *** [/private/tmp/julia-20220504-52502-mmxakk/julia-1.8.0-beta3/deps/srccache/llvmunwind-12.0.1/llvm-libunwind-force-dwarf.patch-applied] Error 1
make[2]: *** Waiting for unfinished jobs....

See this comment: #44499 (comment)

@fxcoudert
Copy link
Contributor

I think the adapted version of the second patch could be this: https://gist.github.com/fxcoudert/1095f33d271c27f4cac63fc0ea37e0c0

@KristofferC KristofferC mentioned this pull request May 16, 2022
67 tasks
@giordano
Copy link
Contributor Author

Superseded by #45189

@giordano giordano closed this May 17, 2022
@giordano giordano deleted the mg/libunwind-epilogue branch May 17, 2022 21:49
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure due to missing patch llvm-libunwind-prologue-epilogue.patch
4 participants