Partially revert PR 42703 to fix embedding with MSVC #44842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quired to successfully embed Julia with MSVC
ViralBShah
approved these changes
Apr 3, 2022
ViralBShah
added
embedding
|
Does this supersede #44587? |
|
No, that example doesn't compile without these changes when the current beta is used. I tested it with 1.7, but I found out it didn't work with the beta today. |
|
Can this still be backported to 1.8, or is it too late? |
KristofferC
pushed a commit
that referenced
this pull request
Apr 19, 2022
Put back a few lines that were removed by PR $42703 because they are required to successfully embed Julia with MSVC. (cherry picked from commit 209aad1)
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes introduced in PR #42703 embedding Julia with MSVC fails with the current beta. A compile error is triggered in platform.h, and the definition of
ios_tis hidden becauseJL_ATTRIBUTE_ALIGN_PTRSIZEis empty. This PR puts back a bit of the MSVC-related code that was removed to fix those two issues.