Add system info to start of testsuite. Profile: don't spawn profile listener on windows #44639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given that the signal handling is not implemented
IanButterworth
force-pushed
the
ib/profile_peek_disable_windows
branch
from
c15c9d1
to
fe4881a
Compare
IanButterworth
force-pushed
the
ib/profile_peek_disable_windows
branch
from
28be992
to
f707e5d
Compare
IanButterworth
changed the title
|
@DilumAluthge I thought the report added to CI here might be helpful for debugging. It's intentionally just before the tests start, to make the memory state relevant. I'll merge once CI is done |
IanButterworth
changed the title
DilumAluthge
removed
the
merge me
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly adds some info to the start of CI runs, to try and help debug recent spurious OOMs or hangs, especially on 32-bit runners.
Secondly disables a spawned task for a profiling feature that isn't functional on windows.
The overhead of having the thread spawned should be negligible, but probably good to do.