Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JIT engine to make it friendlier to multiple contexts #44573

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

pchintalapudi
Copy link
Member

This is a slice of refactors I'm currently using across a few different branches of code (compile-on-demand, multiple contexts) which can be compiled on LLVM 13 and with no other dependent refactors.

@pchintalapudi pchintalapudi added compiler:codegen Generation of LLVM IR and native code compiler:llvm For issues that relate to LLVM labels Mar 11, 2022
@@ -1307,7 +1309,7 @@ void jl_merge_module(Module *dest, std::unique_ptr<Module> src)

// optimize memory by turning long strings into memoized copies, instead of
// making a copy per object file of output.
void jl_jit_share_data(Module &M)
void JuliaOJIT::shareStrings(Module &M)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note, we discussed with Lang that this would be something we could do at the JITLink level instead, but that will have to wait until all platforms use JITLink.

@pchintalapudi pchintalapudi merged commit 0791aef into master Mar 13, 2022
@pchintalapudi pchintalapudi deleted the pc/ee-refactor branch March 13, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code compiler:llvm For issues that relate to LLVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants