Refactor JIT engine to make it friendlier to multiple contexts #44573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchintalapudi
added
compiler:codegen
vchuravy
reviewed
Mar 11, 2022
| @@ -1307,7 +1309,7 @@ void jl_merge_module(Module *dest, std::unique_ptr<Module> src) | |||
|
|
|||
| // optimize memory by turning long strings into memoized copies, instead of | |||
| // making a copy per object file of output. | |||
| void jl_jit_share_data(Module &M) | |||
| void JuliaOJIT::shareStrings(Module &M) | |||
There was a problem hiding this comment.
Just as a note, we discussed with Lang that this would be something we could do at the JITLink level instead, but that will have to wait until all platforms use JITLink.
vtjnash
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slice of refactors I'm currently using across a few different branches of code (compile-on-demand, multiple contexts) which can be compiled on LLVM 13 and with no other dependent refactors.