Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter tests in int.jl #44522

Merged
merged 2 commits into from
Apr 3, 2022
Merged

Stricter tests in int.jl #44522

merged 2 commits into from
Apr 3, 2022

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Mar 8, 2022 •
edited
Loading

Require stricter equality where possible, test BitIntegerType, and test signed on a custom type.

@LilithHafner
Copy link
Member Author

I have a hard time seeing how the test failures (curl: (6) Couldn't resolve host 's3.amazonaws.com') have anything to do with the changes I've made in this PR.

@dkarrasch dkarrasch added the test This change adds or pertains to unit tests label Mar 10, 2022
@LilithHafner
Copy link
Member Author

Bump :) I hope this will be pretty easy to review.

@oscardssmith oscardssmith merged commit f84b49a into JuliaLang:master Apr 3, 2022
@LilithHafner LilithHafner deleted the test-int branch April 4, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilithHafner @oscardssmith @dkarrasch