Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement setproperty! for modules #44231

Merged
merged 7 commits into from
Mar 14, 2022
Merged

implement setproperty! for modules #44231

merged 7 commits into from
Mar 14, 2022

Commits on Feb 19, 2022

  1. implement setproperty! for modules 

    This replaces #44137. As discussed on triage, instead of supporting
modules in `setfield!`, this adds two new builtins `getglobal` and
`setglobal!` explicitly for reading and modifying module bindings. We
should probably consider `getfield(::Module, ::Symbol)` to be
soft-deprecated, but I don't think we want to add any warnings since
that will likely just annoy people.
    @simeonschaub
    simeonschaub committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    bbb5458 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. export getglobal and setglobal!

    @simeonschaub
    simeonschaub committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    fb721f1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sds/getsetglobal

    @simeonschaub
    simeonschaub committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    d3e8d9a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    @simeonschaub @vtjnash
    simeonschaub and vtjnash authored Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ccda59f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. Merge branch 'master' into sds/getsetglobal

    @DilumAluthge
    DilumAluthge authored Mar 13, 2022
    Configuration menu
    Copy the full SHA
    32fd7f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Merge branch 'master' into sds/getsetglobal

    @DilumAluthge
    DilumAluthge authored Mar 14, 2022
    Configuration menu
    Copy the full SHA
    0fc1056 View commit details
    Browse the repository at this point in the history

  2. mention getglobal/setglobal! in NEWS [ci skip]

    @simeonschaub
    simeonschaub committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    778ce05 View commit details
    Browse the repository at this point in the history