Make cholesky handle AbstractMatrix
#44076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
changed the title
cholesky handle HermOrSym of structured matricescholesky handle AbstractMatrix
|
I only now realize that this is somewhat duplicate to #40690, though it includes some special handling for some special matrices, and (currently) doesn't relax the stridedness assumption on inplace @dlfivefifty Do you have an example for a non-strided matrix that should cooperate with |
|
Banded matrices |
|
Do we have some minimal testhelper thing for that, do you know? |
|
I'm not sure we have an easy way to test this, but I checked that |
dkarrasch
force-pushed
the
dk/cholstructured
branch
from
2ac0ac8
to
554ac18
Compare
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
Co-authored-by: Sheehan Olver <s.olver@imperial.ac.uk>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Sheehan Olver <s.olver@imperial.ac.uk>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Sheehan Olver <s.olver@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44053. Closes #40690.