-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system backports for 1.6 #43210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, these all should be backported. Thanks @haampie!
@haampie can you rebase onto |
@nalimilan had some issue with this I think (the p7zip symlink IIRC)? |
Ah yes, thanks for pinging me. I've commented at #43005 (comment). I don't see why that PR should be backported to 1.6. If we do it for this kind of feature, we could do the same for many PRs. What's more, I don't think it's correct in its current implementation. |
d045d0e
to
d4ef4c4
Compare
d4ef4c4
to
7262b35
Compare
I see @nalimilan's point as I only considered install prefixes other than the system root in 43005, so the 7z commit is dropped. |
@KristofferC this PR only backported USE_SYSTEM_LIBWHICH in the end and dropped the p7zip changes. Can that still be added or is that too late now? |
Previously included, now dropped: