Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system backports for 1.6 #43210

Closed

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Nov 24, 2021

Previously included, now dropped:

@haampie haampie changed the title Some backports Build system backports for 1.6 Nov 24, 2021
@ViralBShah ViralBShah added system:32-bit Affects only 32-bit systems domain:building Build system, or building Julia or its dependencies and removed system:32-bit Affects only 32-bit systems labels Nov 24, 2021
@ViralBShah ViralBShah added the backport 1.6 Change should be backported to release-1.6 label Dec 2, 2021
@KristofferC KristofferC mentioned this pull request Dec 2, 2021
29 tasks
Copy link
Sponsor Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, these all should be backported. Thanks @haampie!

@vchuravy vchuravy changed the base branch from release-1.6 to backports-release-1.6 December 6, 2021 19:45
@vchuravy
Copy link
Sponsor Member

vchuravy commented Dec 6, 2021

@haampie can you rebase onto backports-release-1.6?

@KristofferC
Copy link
Sponsor Member

KristofferC commented Dec 6, 2021

@nalimilan had some issue with this I think (the p7zip symlink IIRC)?

@nalimilan
Copy link
Member

Ah yes, thanks for pinging me. I've commented at #43005 (comment). I don't see why that PR should be backported to 1.6. If we do it for this kind of feature, we could do the same for many PRs. What's more, I don't think it's correct in its current implementation.

@haampie
Copy link
Contributor Author

haampie commented Dec 6, 2021

I see @nalimilan's point as I only considered install prefixes other than the system root in 43005, so the 7z commit is dropped.

@KristofferC KristofferC deleted the branch JuliaLang:backports-release-1.6 December 11, 2021 09:28
@haampie
Copy link
Contributor Author

haampie commented Dec 11, 2021

@KristofferC this PR only backported USE_SYSTEM_LIBWHICH in the end and dropped the p7zip changes. Can that still be added or is that too late now?

@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants