Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UndefVarError due to unintentional signature change #43173

Merged
merged 5 commits into from
Nov 22, 2021
Merged

Fix UndefVarError due to unintentional signature change #43173

merged 5 commits into from
Nov 22, 2021

Conversation

BioTurboNick
Copy link
Contributor

@vtjnash was introduced by #40642

@ararslan
Copy link
Member

Is it possible to add a test that would have caught this in the original PR, or is this what caused the (not particularly transparent) UNHANDLED TASK ERROR: IOError: stream is closed or unusable errors on Linux and FreeBSD on that PR? It probably shouldn't have been merged with those failures.

@BioTurboNick
Copy link
Contributor Author

I don't know why this would have caused an error specifically on Linux or FreeBSD... But adding a test to make sure this path works seems reasonable.

@vtjnash
Copy link
Member

vtjnash commented Nov 20, 2021

The PR likely needed to wait for the REPL task to exit, following whatever the other test do

@BioTurboNick
Copy link
Contributor Author

Think I got it. Needed an end of transmission character and then the wait.

@ararslan ararslan requested a review from vtjnash November 21, 2021 22:22
@Keno Keno merged commit b078d77 into JuliaLang:master Nov 22, 2021
@Keno Keno mentioned this pull request Nov 22, 2021
Closed
@BioTurboNick BioTurboNick mentioned this pull request Nov 27, 2021
Closed
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@BioTurboNick @LilithHafner
Fix UndefVarError due to unintentional signature change (JuliaLang#43173
05d62b2 
)

* Fix UndefVarError due to unintentional signature change

* Add wait for REPL task to exit

* Add test

* test fix

* no invoke
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@BioTurboNick @LilithHafner
Fix UndefVarError due to unintentional signature change (JuliaLang#43173
974948b 
)

* Fix UndefVarError due to unintentional signature change

* Add wait for REPL task to exit

* Add test

* test fix

* no invoke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BioTurboNick @ararslan @vtjnash @Keno