Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stale_cachefile compatible with Nix mtime #43090

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Make stale_cachefile compatible with Nix mtime #43090

merged 1 commit into from
Nov 19, 2021

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Nov 15, 2021

The added condition improves compatibility with Nix mtime. Best! :)

The added condition improves compatiblity with Nix mtime.
@Sacha0 Sacha0 added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 15, 2021
@vtjnash vtjnash merged commit f5e0f9d into master Nov 19, 2021
@vtjnash vtjnash deleted the sv-nix-mtime branch November 19, 2021 19:15
@vtjnash
Copy link
Sponsor Member

vtjnash commented Nov 19, 2021

I wonder if we could stop recording include'd files times if their read-only bits are set, possibly saving us some stat calls

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 19, 2021

Incidentally, in the last couple days I tested running without this patch (on a much more recent Nix build than the patch was originally written against), and our test suite appears to succeed without out. So it may be safe to drop this patch 😄.

@Sacha0
Copy link
Member Author

Sacha0 commented Nov 20, 2021

So it may be safe to drop this patch 😄.

A little update: Our Nix guru (@rbvermaa) thinks that other Nix users will nonetheless benefit from inclusion of this patch, so it seems worthwhile :).

KristofferC pushed a commit that referenced this pull request Nov 25, 2021
The added condition improves compatiblity with Nix mtime.

(cherry picked from commit f5e0f9d)
KristofferC pushed a commit that referenced this pull request Nov 26, 2021
The added condition improves compatiblity with Nix mtime.

(cherry picked from commit f5e0f9d)
KristofferC pushed a commit that referenced this pull request Nov 26, 2021
The added condition improves compatiblity with Nix mtime.

(cherry picked from commit f5e0f9d)
KristofferC pushed a commit that referenced this pull request Dec 2, 2021
The added condition improves compatiblity with Nix mtime.

(cherry picked from commit f5e0f9d)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Dec 11, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
The added condition improves compatiblity with Nix mtime.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
The added condition improves compatiblity with Nix mtime.
@DilumAluthge
Copy link
Member

I wonder if we could stop recording include'd files times if their read-only bits are set, possibly saving us some stat calls

I don't think this is safe. I've run into situations in various CI environments where, even if you set a file to be read-only, you can still modify the file later in the CI job.

To be safe, I don't think we should assume that a read-only file will not be modified later.

staticfloat pushed a commit that referenced this pull request Dec 23, 2022
The added condition improves compatiblity with Nix mtime.

(cherry picked from commit f5e0f9d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants