-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make stale_cachefile compatible with Nix mtime #43090
Conversation
The added condition improves compatiblity with Nix mtime.
I wonder if we could stop recording |
Incidentally, in the last couple days I tested running without this patch (on a much more recent Nix build than the patch was originally written against), and our test suite appears to succeed without out. So it may be safe to drop this patch 😄. |
A little update: Our Nix guru (@rbvermaa) thinks that other Nix users will nonetheless benefit from inclusion of this patch, so it seems worthwhile :). |
The added condition improves compatiblity with Nix mtime. (cherry picked from commit f5e0f9d)
The added condition improves compatiblity with Nix mtime. (cherry picked from commit f5e0f9d)
The added condition improves compatiblity with Nix mtime. (cherry picked from commit f5e0f9d)
The added condition improves compatiblity with Nix mtime. (cherry picked from commit f5e0f9d)
The added condition improves compatiblity with Nix mtime.
The added condition improves compatiblity with Nix mtime.
I don't think this is safe. I've run into situations in various CI environments where, even if you set a file to be read-only, you can still modify the file later in the CI job. To be safe, I don't think we should assume that a read-only file will not be modified later. |
The added condition improves compatiblity with Nix mtime. (cherry picked from commit f5e0f9d)
The added condition improves compatibility with Nix mtime. Best! :)