Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running make testall should run all of the tests #42904

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Running make testall should run all of the tests #42904

merged 1 commit into from
Nov 7, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Nov 2, 2021 •
edited
Loading

Description

Before this pull request:

  1. make test will run all tests except Pkg and LibGit2/online.
  2. make testall will run all tests except Pkg and LibGit2/online.

After this pull request:

  1. make test will run all tests except Pkg and LibGit2/online.
  2. make testall will run all tests.

Motivation

If you do make testall, don't you expect it to run all of the tests?

@DilumAluthge DilumAluthge added domain:building Build system, or building Julia or its dependencies testsystem The unit testing framework and Test stdlib domain:ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 2, 2021
@DilumAluthge DilumAluthge marked this pull request as ready for review November 4, 2021 22:54
staticfloat
staticfloat approved these changes Nov 4, 2021
View reviewed changes
test/Makefile Show resolved Hide resolved
@DilumAluthge DilumAluthge requested review from vtjnash and removed request for vtjnash November 6, 2021 23:36
@DilumAluthge DilumAluthge added the status:merge me PR is reviewed. Merge when all tests are passing label Nov 6, 2021
@DilumAluthge DilumAluthge merged commit 36304ba into master Nov 7, 2021
@DilumAluthge DilumAluthge deleted the dpa/make-testall branch November 7, 2021 07:04
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Nov 7, 2021
This was referenced Nov 7, 2021
Merged
Merged
KristofferC pushed a commit that referenced this pull request Nov 9, 2021
@DilumAluthge @KristofferC
Running make testall should run all of the tests (#42904)
3479d89 
(cherry picked from commit 36304ba)
daviehh pushed a commit to daviehh/julia that referenced this pull request Nov 16, 2021
@DilumAluthge @daviehh
Running make testall should run all of the tests (JuliaLang#42904)
c7b6d62 
(cherry picked from commit 36304ba)
@KristofferC KristofferC mentioned this pull request Nov 19, 2021
Merged
29 tasks
@KristofferC KristofferC mentioned this pull request Jan 10, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@DilumAluthge @LilithHafner
Running make testall should run all of the tests (JuliaLang#42904)
e05404f
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@DilumAluthge @LilithHafner
Running make testall should run all of the tests (JuliaLang#42904)
1e1ff7d
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@DilumAluthge
Running make testall should run all of the tests (#42904)
79388bf 
(cherry picked from commit 36304ba)
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@DilumAluthge
Running make testall should run all of the tests (#42904)
cdfbec3 
(cherry picked from commit 36304ba)
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@DilumAluthge
Running make testall should run all of the tests (#42904)
c7daef8 
(cherry picked from commit 36304ba)
KristofferC pushed a commit that referenced this pull request Mar 18, 2022
@DilumAluthge @KristofferC
Running make testall should run all of the tests (#42904)
356a116 
(cherry picked from commit 36304ba)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@DilumAluthge @staticfloat
Running make testall should run all of the tests (#42904)
4ddc4f5 
(cherry picked from commit 36304ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
domain:building Build system, or building Julia or its dependencies domain:ci Continuous integration testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DilumAluthge @staticfloat @vtjnash @KristofferC