Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make read() respect lock=false #42394

Merged
merged 1 commit into from
Sep 28, 2021
Merged

make read() respect lock=false #42394

merged 1 commit into from
Sep 28, 2021

Conversation

Moelf
Copy link
Sponsor Contributor

@Moelf Moelf commented Sep 26, 2021

Close #42393

@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Sep 27, 2021
@Moelf
Copy link
Sponsor Contributor Author

Moelf commented Sep 27, 2021

can we backport this to 1.7? since it has some pretty hefty performance implication

@vchuravy vchuravy added domain:io Involving the I/O subsystem: libuv, read, write, etc. backport 1.7 labels Sep 28, 2021
@vchuravy vchuravy merged commit 167984d into JuliaLang:master Sep 28, 2021
@Moelf Moelf deleted the read_lock_false branch September 28, 2021 21:42
@IanButterworth IanButterworth removed the status:merge me PR is reviewed. Merge when all tests are passing label Sep 29, 2021
@KristofferC KristofferC mentioned this pull request Sep 29, 2021
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@StefanKarpinski StefanKarpinski Awaiting requested review from StefanKarpinski

Assignees
No one assigned
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read(s::IOStream, T::Union{Type{Int16},Type{UInt16}...}) doesn't respect ;lock = false
5 participants
@Moelf @vtjnash @vchuravy @KristofferC @IanButterworth