[GMP] Patch for Apple Silicon

[jeremiahpslewis]

GMP appears to need a patch for Arm64, thank you to @domschl for finding this!

Ideally, this will resolve #42184

[vchuravy]

Can you also add the patch to https://github.com/JuliaPackaging/Yggdrasil/tree/master/G/GMP?

[jeremiahpslewis]

@vchuravy Let me see if I can walk this PR to the finish line, and then I’d gladly do the same for Yggrasil…so far this is more of a shot in the dark based on @domschl’s tip. :)

[jeremiahpslewis]

@mryodo Can you test this on your machine and confirm the build now works?

[mryodo]

@mryodo Can you test this on your machine and confirm the build now works?

Sure! Thanks for the work, man, builds perfectly for me on the 1.8.0-DEV
OpenBLAS is still broken though same as on 1.7.0-**, i've reopened the issue #42176

[jeremiahpslewis]

Does anyone know if there are license compatibility issues with incorporating this patch into the Julia repo? Afaict gmp is GPL/LGPL...

[stevengj]

Can't you just s/x18/x17/g on the file rather than using patch? That will avoid copyright questions. I guess there is no single register rename that works in all the cases?

[stevengj]

Has someone reported this upstream to gmp-bugs@gmplib.org yet?

[domschl]

@stevengj : The patch was provided by upstream.

[staticfloat]

Looks great to me!

[vchuravy]

Great! Now the adding the patch to Yggrdasil and also bumping the GMB build we use when not building from source would be the next step.

[jeremiahpslewis]

Yggdrasil patch is already available, here: JuliaPackaging/Yggdrasil#3640

[jeremiahpslewis]

Not sure what you mean about the non-source gmb lib version, can you flesh out your comment?

[vchuravy]

Yggdrasil patch is already available, here: JuliaPackaging/Yggdrasil#3640

Okay landed.

Can you bump

julia/stdlib/GMP_jll/Project.toml

Line 3 in 52ec8c6

version = "6.2.1+0"

to 6.2.1+1

and then make -f contrib/refresh_checksums.mk GMP (on my phone but hopefully I remembered the right command).

This will update what binary we will pull down when we don't build against the source version. A build from BinaryBuilder is the default (on CI as well)

[jeremiahpslewis]

Pushed updates.

[vchuravy]

Something went wrong. It should have updated https://github.com/JuliaLang/julia/blob/master/deps/checksums/gmp instead of creating many files.

@staticfloat any ideas?

[jeremiahpslewis]

@vchuravy didn't let the script run all the way through. Fixed and pushed.

[vchuravy]

@vchuravy didn't let the script run all the way through. Fixed and pushed.

Not seeing the push, yet :)

[jeremiahpslewis]

@vchuravy didn't let the script run all the way through. Fixed and pushed.

Not seeing the push, yet :)

Force push failed on me. Now. :)