optimizer: fix #42246, set ssaflags correctly when inserting coverage statements
#42260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/fix42246
branch
from
760a229 to
29ab5f5
Compare
KristofferC
reviewed
Sep 15, 2021
test/compiler/inline.jl
Outdated
| local back = pwd() | ||
| try | ||
| @test mktempdir() do dir | ||
| cd(dir) |
There was a problem hiding this comment.
Possible to use cd(dir) do... here?
aviatesk
force-pushed
the
avi/fix42246
branch
from
29ab5f5 to
86af793
Compare
aviatesk
added a commit
that referenced
this pull request
Sep 15, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
…ge statements It seems that this change still doesn't resolve #42258 though.
aviatesk
force-pushed
the
avi/fix42246
branch
from
86af793 to
c8b24f7
Compare
aviatesk
added a commit
that referenced
this pull request
Sep 18, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
aviatesk
added a commit
that referenced
this pull request
Sep 20, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
aviatesk
added a commit
that referenced
this pull request
Sep 21, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
aviatesk
added a commit
that referenced
this pull request
Sep 22, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
aviatesk
added a commit
that referenced
this pull request
Sep 22, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of #42260.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…ng coverage statements (JuliaLang#42260) It seems that this change still doesn't resolve JuliaLang#42258 though.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…JuliaLang#42262) Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of JuliaLang#42260.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ng coverage statements (JuliaLang#42260) It seems that this change still doesn't resolve JuliaLang#42258 though.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…JuliaLang#42262) Essentially, this PR adds missing `ssaflags` deletion of `type_annotate!`. Built on top of JuliaLang#42260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this change still doesn't resolve #42258 though.