Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference: fix #42148, run find_throw_blocks once before inference #42149

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

aviatesk
Copy link
Sponsor Member

@aviatesk aviatesk commented Sep 7, 2021

With this commit, we mark src.ssaflags before inference, and optimizer
will just observe them.

With this commit, we mark `src.ssaflags` before inference, and optimizer
will just observe them.
@vtjnash vtjnash merged commit ed3691f into master Sep 8, 2021
@vtjnash vtjnash deleted the avi/throwdeopt branch September 8, 2021 15:54
aviatesk added a commit to aviatesk/JET.jl that referenced this pull request Sep 8, 2021
aviatesk added a commit to aviatesk/JET.jl that referenced this pull request Sep 8, 2021
aviatesk added a commit to aviatesk/JET.jl that referenced this pull request Sep 8, 2021
aviatesk added a commit to aviatesk/JET.jl that referenced this pull request Sep 8, 2021
aviatesk added a commit to aviatesk/JET.jl that referenced this pull request Sep 8, 2021
@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 8, 2021

This is triggering an error in the Serialization test

$ make Serialization
    JULIA test/Serialization                                                                                   
Test      (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB) 
Serialization  (1) |        started at 2021-09-08T17:27:38.640
Internal error: encountered unexpected error in runtime:
BoundsError(a=Array{UInt8, (0,)}[], i=(1,))                                                                    
jl_bounds_error_ints at /data/vtjnash/julia/src/rtutils.c:194                                    
getindex at ./array.jl:904 [inlined]                                                                           
get_curr_ssaflag at ./compiler/inferencestate.jl:382 [inlined] 
abstract_call_gf_by_type at ./compiler/abstractinterpretation.jl:34
...

aviatesk added a commit that referenced this pull request Sep 9, 2021
Makes sure the length of `ssaflags` matches that of `code`, so that the
latest inference doesn't throw on IRs serialized from old versions.

ref: <#42149 (comment)>
vtjnash pushed a commit that referenced this pull request Sep 9, 2021
Makes sure the length of `ssaflags` matches that of `code`, so that the
latest inference doesn't throw on IRs serialized from old versions.

Ref: <#42149 (comment)>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…2149)

With this commit, we mark `src.ssaflags` before inference, and optimizer
will just observe them.

Fixes JuliaLang#42148
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…g#42177)

Makes sure the length of `ssaflags` matches that of `code`, so that the
latest inference doesn't throw on IRs serialized from old versions.

Ref: <JuliaLang#42149 (comment)>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…2149)

With this commit, we mark `src.ssaflags` before inference, and optimizer
will just observe them.

Fixes JuliaLang#42148
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…g#42177)

Makes sure the length of `ssaflags` matches that of `code`, so that the
latest inference doesn't throw on IRs serialized from old versions.

Ref: <JuliaLang#42149 (comment)>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants