-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inference: fix #42148, run find_throw_blocks
once before inference
#42149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, we mark `src.ssaflags` before inference, and optimizer will just observe them.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Sep 8, 2021
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Sep 8, 2021
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Sep 8, 2021
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Sep 8, 2021
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Sep 8, 2021
This is triggering an error in the Serialization test
|
aviatesk
added a commit
that referenced
this pull request
Sep 9, 2021
Makes sure the length of `ssaflags` matches that of `code`, so that the latest inference doesn't throw on IRs serialized from old versions. ref: <#42149 (comment)>
vtjnash
pushed a commit
that referenced
this pull request
Sep 9, 2021
Makes sure the length of `ssaflags` matches that of `code`, so that the latest inference doesn't throw on IRs serialized from old versions. Ref: <#42149 (comment)>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…2149) With this commit, we mark `src.ssaflags` before inference, and optimizer will just observe them. Fixes JuliaLang#42148
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…g#42177) Makes sure the length of `ssaflags` matches that of `code`, so that the latest inference doesn't throw on IRs serialized from old versions. Ref: <JuliaLang#42149 (comment)>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…2149) With this commit, we mark `src.ssaflags` before inference, and optimizer will just observe them. Fixes JuliaLang#42148
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…g#42177) Makes sure the length of `ssaflags` matches that of `code`, so that the latest inference doesn't throw on IRs serialized from old versions. Ref: <JuliaLang#42149 (comment)>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, we mark
src.ssaflags
before inference, and optimizerwill just observe them.