Fix ~370 invalidations from Expr(:ncat, ...) pretty-printing #41877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
approved these changes
Aug 13, 2021
5 tasks
|
A codegen performance test seems to be unexpectedly unhappy with this, but LGTM |
|
How can I see the codegen performance test? I could get rid of the |
|
Yes, that might be preferable. A type assertion error seems more appropriate here than a conversion error in case someone generated an invalid AST. |
These get invalidated by loading Static.jl, specifically the method
```
Base.convert(::Type{T}, ::StaticInt{N}) where {T<:Number,N} = convert(T, N)
```
timholy
force-pushed
the
teh/inval_show_ncat
branch
from
a218f6a
to
b66dbe1
Compare
vtjnash
added
the
status:merge me
|
It was probably just something transient and weird about CI at the time |
DilumAluthge
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
These get invalidated by loading Static.jl, specifically the method
```
Base.convert(::Type{T}, ::StaticInt{N}) where {T<:Number,N} = convert(T, N)
```
(cherry picked from commit 232ee11)
63 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…ng#41877) These get invalidated by loading Static.jl, specifically the method ``` Base.convert(::Type{T}, ::StaticInt{N}) where {T<:Number,N} = convert(T, N) ```
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ng#41877) These get invalidated by loading Static.jl, specifically the method ``` Base.convert(::Type{T}, ::StaticInt{N}) where {T<:Number,N} = convert(T, N) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These get invalidated by loading Static.jl, specifically the method
CC @ChrisRackauckas