Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a precision issue in abstract_iteration #41839

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Fix a precision issue in abstract_iteration #41839

merged 5 commits into from
Aug 30, 2021

Commits on Aug 24, 2021

  1. Fix a precision issue in abstract_iteration 

    If the first loop exits in the first iteration, the `statetype` is still
`Bottom`. In that case, the new `stateordonet` needs to be determined
with the two-arg version of `iterate` again.

Fixes #41022.
    @martinholters
    martinholters committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    1d553b8 View commit details
    Browse the repository at this point in the history

  2. Slightly simplify abstract_iteration

    @martinholters
    martinholters committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    423dc65 View commit details
    Browse the repository at this point in the history

  3. Add inference soundness test for splatting long range 

    Explicitly test that inference produces a sound (and reasonably precise)
result when splatting an iterator (in this case a long range) that
allows constant-propagation up to the `MAX_TUPLE_SPLAT` limit.
    @martinholters
    martinholters committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    bbfeb79 View commit details
    Browse the repository at this point in the history

  4. Optimize abstract_iteration a little bit 

    Avoid recomputation of a `widenconst` and initialize `valtype` and
`statetype` to `Bottom` before second loop to simplify a `⊑`to a `<:`
there.
    @martinholters
    martinholters committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    75372b2 View commit details
    Browse the repository at this point in the history

  5. Improve abstract_iteration for failing and infinte iterators

    @martinholters
    martinholters committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    8669893 View commit details
    Browse the repository at this point in the history