Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "upgrade libuv to v2-1.42.0" and revert "add stream shutdown and support half-duplex operation" #41802

Closed
wants to merge 2 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Aug 6, 2021

The first commit reverts #41710

The second commit reverts #40783 by way of #41808

Only the first commit should be backported to release-1.7.

@DilumAluthge DilumAluthge added backport 1.7 external dependencies Involves LLVM, OpenBLAS, or other linked libraries domain:io Involving the I/O subsystem: libuv, read, write, etc. labels Aug 6, 2021
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Aug 6, 2021

Before merging this PR, we should make sure that:

  1. All of the FreeBSD CI jobs (package and tester) are passing
  2. All of the FreeBSD CI jobs ran on workers running FreeBSD 11 (workers that end in amdci6_1, amdci6_2, or amdci6_3)

@ararslan
Copy link
Member

ararslan commented Aug 6, 2021

I believe FreeBSD will need #41808 in order to pass tests.

@ararslan
Copy link
Member

ararslan commented Aug 6, 2021

Seems Linux x86 is failing with the same error. I've changed the base branch of the aforementioned PR to be this PR, so merging that will include the changes here. Note that this PR will need to be manually backported, as only the first revert commit (the original in this PR) is relevant to 1.7.

@DilumAluthge DilumAluthge marked this pull request as draft August 6, 2021 22:37
@DilumAluthge DilumAluthge changed the title Revert "upgrade libuv to v2-1.42.0" Revert "upgrade libuv to v2-1.42.0" and revert "add stream shutdown and support half-duplex operation" Aug 6, 2021
@DilumAluthge DilumAluthge marked this pull request as ready for review August 6, 2021 23:29
@DilumAluthge DilumAluthge force-pushed the revert-41710-jn/uv2-1.42.0 branch 2 times, most recently from aad52ec to 6fa35ce Compare August 7, 2021 03:43
@DilumAluthge DilumAluthge reopened this Aug 7, 2021
@DilumAluthge DilumAluthge deleted the revert-41710-jn/uv2-1.42.0 branch August 9, 2021 22:03
@DilumAluthge DilumAluthge restored the revert-41710-jn/uv2-1.42.0 branch August 10, 2021 21:22
@DilumAluthge DilumAluthge reopened this Aug 10, 2021
@DilumAluthge DilumAluthge deleted the revert-41710-jn/uv2-1.42.0 branch August 12, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:io Involving the I/O subsystem: libuv, read, write, etc. external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants