Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix julia_asserts to depend only on julia build mode #41482

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

JeffBezanson
Copy link
Member

Assertions in parts of our C++ code seemed to always be enabled; for example in #41157 where the assertion happens in all builds. This moves some includes and fixes the logic in julia_assert.h to make assertions in our code depend only on JL_NDEBUG.
A couple remaining questions about assertions:

  • Should we inspect llvm-config --assertion-mode and pass -DNDEBUG (in addition to the existing -DJL_NDEBUG) if LLVM assertions are off?
  • We could look into using EnableABIBreakingChecksin LLVM, which adds more checks at the cost of requiring the flag to match in callers.

@JeffBezanson JeffBezanson added building Build system, or building Julia or its dependencies bugfix This change fixes an existing bug labels Jul 6, 2021
@vtjnash vtjnash merged commit 55a873e into master Jul 21, 2021
@vtjnash vtjnash deleted the jb/llvmasserts branch July 21, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants