fix julia_asserts to depend only on julia build mode #41482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertions in parts of our C++ code seemed to always be enabled; for example in #41157 where the assertion happens in all builds. This moves some includes and fixes the logic in julia_assert.h to make assertions in our code depend only on JL_NDEBUG.
A couple remaining questions about assertions:
llvm-config --assertion-mode
and pass -DNDEBUG (in addition to the existing -DJL_NDEBUG) if LLVM assertions are off?