TOML: fix some printing of special characters #41079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix some printing of special characters
stevengj
reviewed
Jun 4, 2021
vtjnash
reviewed
Jun 9, 2021
| @test roundtrip(s) | ||
|
|
||
| d = Dict("str" => string(Char(0xd800))) | ||
| @test_throws ErrorException TOML.print(d) |
There was a problem hiding this comment.
This appears to have introduced this defect in the test output:
TOML (41) | 31.70 | 0.67 | 2.1 | 1230.28 | 1353.48
From worker 41: str = "
Suggested change
| @test_throws ErrorException TOML.print(d) | |
| @test_throws ErrorException TOML.print(devnull, d) |
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
* TOML: fix some printing of special characters
45 tasks
KristofferC
added a commit
that referenced
this pull request
Jun 10, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* TOML: fix some printing of special characters
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/TOML.jl#22.