Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ModFlag for Debug Info Version to Warning #40653

Merged
merged 1 commit into from
May 4, 2021
Merged

Set ModFlag for Debug Info Version to Warning #40653

merged 1 commit into from
May 4, 2021

Conversation

vchuravy
Copy link
Member

Other producers like Clang, set this to warning instead of error,
which can cause spurious failures when linking in bitcode files.

Julia module:

!llvm.module.flags = !{!0, !1}

!0 = !{i32 2, !"Dwarf Version", i32 4}
!1 = !{i32 1, !"Debug Info Version", i32 3}

Bitcode file produced by Clang:

!386 = !{i32 2, !"Debug Info Version", i32 3}

Leading to the fun:

error: linking module flags 'Debug Info Version': IDs have conflicting behaviors in 'usr/lib/libopencilk-abi.bc' and 'test_loop'

cc: @neboat @tkf

@vchuravy vchuravy added the compiler:codegen Generation of LLVM IR and native code label Apr 29, 2021
@vchuravy vchuravy requested a review from Keno April 29, 2021 00:26
@vtjnash vtjnash merged commit 0f2ad74 into master May 4, 2021
@vtjnash vtjnash deleted the vc/modflag branch May 4, 2021 18:28
@vchuravy vchuravy added the backport 1.6 Change should be backported to release-1.6 label May 8, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@vchuravy @antoine-levitt
codegen: set ModFlag for Debug Info Version to Warning (JuliaLang#4…
890c952 
…0653)

This allows linking the resulting code against another bitcode library (such as libopencilk-abi.bc) that was built with a different version of llvm debug info.
dghosef pushed a commit to dghosef/julia that referenced this pull request May 11, 2021
@vchuravy @dghosef
codegen: set ModFlag for Debug Info Version to Warning (JuliaLang#4…
f030e65 
…0653)

This allows linking the resulting code against another bitcode library (such as libopencilk-abi.bc) that was built with a different version of llvm debug info.
KristofferC pushed a commit that referenced this pull request May 11, 2021
@vchuravy @KristofferC
codegen: set ModFlag for Debug Info Version to Warning (#40653)
70bfa4d 
This allows linking the resulting code against another bitcode library (such as libopencilk-abi.bc) that was built with a different version of llvm debug info.

(cherry picked from commit 0f2ad74)
@KristofferC KristofferC mentioned this pull request May 11, 2021
Merged
45 tasks
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@vchuravy @johanmon
codegen: set ModFlag for Debug Info Version to Warning (JuliaLang#4…
eca7795 
…0653)

This allows linking the resulting code against another bitcode library (such as libopencilk-abi.bc) that was built with a different version of llvm debug info.
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vchuravy @staticfloat
codegen: set ModFlag for Debug Info Version to Warning (#40653)
e07a0b9 
This allows linking the resulting code against another bitcode library (such as libopencilk-abi.bc) that was built with a different version of llvm debug info.

(cherry picked from commit 0f2ad74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vchuravy @vtjnash @KristofferC