unexport cat_shape #40549
Merged
unexport cat_shape #40549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This symbol is unexpectedly exported by the `deprecate` marco
|
You can use |
KristofferC
approved these changes
Apr 21, 2021
|
Seems to have broken a handful of packages (https://github.com/JuliaCI/NanosoldierReports/blob/master/pkgeval/by_date/2021-04/22/report.md) |
|
A patch version of Tullio mcabbott/Tullio.jl#100 looks sufficient to fix this (all affected versions are Tullio v0.2.x series). However, I don't know what's the "best practice" to handle such cases... |
KristofferC
pushed a commit
that referenced
this pull request
May 4, 2021
(cherry picked from commit ca6df85)
45 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit ca6df85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This symbol was unexpectedly exported by the
deprecatemacroresolves the comment in #36838 (comment)
Should we backport this to 1.6?
cc: @mbauman