docs: mention privacy of type fields in style-guide #40533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
approved these changes
Apr 19, 2021
vtjnash
pushed a commit
that referenced
this pull request
Apr 20, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
close JuliaLang#12064 close JuliaLang#7561 Co-authored-by: Spencer Russell <spencer.f.russell@gmail.com>
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Provides some guidelines, in addition to those added recently by JuliaLang#40533 to the style-guide, per JuliaLang#7561.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
close JuliaLang#12064 close JuliaLang#7561 Co-authored-by: Spencer Russell <spencer.f.russell@gmail.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Provides some guidelines, in addition to those added recently by JuliaLang#40533 to the style-guide, per JuliaLang#7561.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
close JuliaLang#12064 close JuliaLang#7561 Co-authored-by: Spencer Russell <spencer.f.russell@gmail.com>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Provides some guidelines, in addition to those added recently by JuliaLang#40533 to the style-guide, per JuliaLang#7561.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #12083, which this rebases, changes to markdown, changes some wordings, and adds some clarification and counter-examples (I can't push the rebase there). Closes #12064 and #7561