Allow CartesianIndices with Bool argument #39962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to the problem discussed in JuliaLang#31829 (comment). I came to the conclusion that `CartesianIndices((true,))` should be allowed as in this context `true` represents a dimension length not an index.
vtjnash
reviewed
Mar 12, 2021
| @@ -278,6 +278,7 @@ module IteratorsMD | |||
|
|
|||
| CartesianIndices(A::AbstractArray) = CartesianIndices(axes(A)) | |||
|
|
|||
| _convert2ind(sz::Bool) = Base.OneTo(Int(sz)) | |||
There was a problem hiding this comment.
Should we use Int8 here, so it doesn't occupy more memory?
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
Follow up to the problem discussed in JuliaLang#31829 (comment). I came to the conclusion that `CartesianIndices((true,))` should be allowed as in this context `true` represents a dimension length not an index.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Follow up to the problem discussed in JuliaLang#31829 (comment). I came to the conclusion that `CartesianIndices((true,))` should be allowed as in this context `true` represents a dimension length not an index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the problem discussed in #31829 (comment).
I came to the conclusion that
CartesianIndices((true,))should be allowed as in this contexttruerepresents a dimension length not an index.