Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn, not error, on precompile failure #39922

Closed
wants to merge 1 commit into from
Closed

Warn, not error, on precompile failure #39922

wants to merge 1 commit into from

Conversation

timholy
Copy link
Sponsor Member

@timholy timholy commented Mar 5, 2021

xref #39905. That has some extra goodies in it so this doesn't replace it, but it is an alternative approach for part of it.

xref #39905. That has some extra goodies in it so this doesn't replace it.
@vtjnash
Copy link
Sponsor Member

vtjnash commented Mar 5, 2021

I think it is just conceptually flawed here to return a bool. We shouldn't need this much code-generation around doing a function call. It is not very flexible and has a tendency to bit-rot.

For #39905, I considered adding a nowarn::Bool=false default option though. Or warnversion::VersionNumber=VERSION (which warns only if VERSION <= warnversion). Thoughts?

@timholy
Copy link
Sponsor Member Author

timholy commented Mar 5, 2021

If you think the bool is flawed then sure, let's use your design. If you agree that we sometimes really do want to hard-fail if the precompile fails...what about two keywords, warn::Bool=false, err::Bool=false. Or perhaps mode::Symbol=:silent with :warn and :err as two other options.

I don't yet see the reason to supply a version number, so perhaps you could explain the reasoning there.

@kimikage
Copy link
Contributor

kimikage commented Mar 6, 2021

xref: timholy/SnoopCompile.jl#243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants