llvm-alloc-opt: handle dead code better #39801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases (particularly after removing a phi node), we might end up in a circumstance where it appears statically that we would use a slot for both a ref and bits. Avoid generating malformed IR in this case. In the future, this situation could also possibly happen if we walked through phi nodes and attempted to merge the contents (with great care).
vtjnash
added
bugfix
KristofferC
pushed a commit
that referenced
this pull request
Mar 14, 2021
In some cases (particularly after removing a phi node), we might end up in a circumstance where it appears statically that we would use a slot for both a ref and bits. Avoid generating malformed IR in this case. In the future, this situation could also possibly happen if we walked through phi nodes and attempted to merge the contents (with great care). (cherry picked from commit 9e783bb)
14 tasks
Closed
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
In some cases (particularly after removing a phi node), we might end up in a circumstance where it appears statically that we would use a slot for both a ref and bits. Avoid generating malformed IR in this case. In the future, this situation could also possibly happen if we walked through phi nodes and attempted to merge the contents (with great care).
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
In some cases (particularly after removing a phi node), we might end up in a circumstance where it appears statically that we would use a slot for both a ref and bits. Avoid generating malformed IR in this case. In the future, this situation could also possibly happen if we walked through phi nodes and attempted to merge the contents (with great care).
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
In some cases (particularly after removing a phi node), we might end up in a circumstance where it appears statically that we would use a slot for both a ref and bits. Avoid generating malformed IR in this case. In the future, this situation could also possibly happen if we walked through phi nodes and attempted to merge the contents (with great care). (cherry picked from commit 9e783bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (particularly after removing a phi node), we might end up
in a circumstance where it appears statically that we would use a slot
for both a ref and bits. Avoid generating malformed IR in this case.
In the future, this situation could also possibly happen if we walked
through phi nodes and attempted to merge the contents (with great care).
Refs #39641