-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Some degree trigonometric functions, sind
, cosd
, tand
, asind
, acosd
, asecd
, acsd
, acotd
, atand
accept a square matrix.
#39758
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d88c1cd
Some degree trigonometric functions, `sind`, `cosd`, `tand`, `asind`,…
AtsushiSakai a27bff1
add PR number and change argument name to be the same as in the docum…
AtsushiSakai 8af8977
Merge branch 'master' into issue_32876
AtsushiSakai 7f98419
Merge branch 'master' into issue_32876
AtsushiSakai 70d35bd
Update NEWS.md
ViralBShah 402df53
Merge branch 'master' into issue_32876
AtsushiSakai 5acd450
add `atand` for News.md.
AtsushiSakai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -341,6 +341,35 @@ end | |
@test Array(acosh.(STAA)) == acosh.(TAA) | ||
@test Array(acsch.(STAA)) == acsch.(TAA) | ||
@test Array(acoth.(STAA)) == acoth.(TAA) | ||
@test sind(TAA) == sin(deg2rad.(TAA)) | ||
@test cosd(TAA) == cos(deg2rad.(TAA)) | ||
@test tand(TAA) == tan(deg2rad.(TAA)) | ||
@test asind(TAA) == rad2deg.(asin(TAA)) | ||
@test acosd(TAA) == rad2deg.(acos(TAA)) | ||
@test atand(TAA) == rad2deg.(atan(TAA)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ViralBShah |
||
@test asecd(TAA) == rad2deg.(asec(TAA)) | ||
@test acscd(TAA) == rad2deg.(acsc(TAA)) | ||
@test acotd(TAA) == rad2deg.(acot(TAA)) | ||
|
||
m = rand(3,2) # not square matrix | ||
ex = @test_throws DimensionMismatch sind(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch cosd(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch tand(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch asind(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch acosd(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch atand(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch asecd(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch acscd(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
ex = @test_throws DimensionMismatch acotd(m) | ||
@test startswith(ex.value.msg, "matrix is not square") | ||
end | ||
|
||
@testset "check exp2(::Integer) matches exp2(::Float)" begin | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ViralBShah Thank you for your comment. The PR title and news.md was missing
atand
, but it supports a square matrix by this change.